fix(v2): make config validation less strict #3120
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
This PR modifies the config validation for the following fields:
navbar.title
It allows the following values for navbar.title:
''
,null
,undefined
. This fixes #3117.rehypePlugins
The schema for rehypePlugins has been modified. It now accepts an array, whose items are either:
This fixes #3125.
routeBasePath
It accepts the empty string
''
now. This is useful for removing/docs
from url while having a landing page. This fixes #3126.scripts and stylesheets
scripts accepts both defer and async now.
stylesheets accepts unknown fields now.
This fixes #3128
Have you read the Contributing Guidelines on pull requests?
Yes
Test Plan
navbar.title
/website/docusaurus.config.js
, change navbar.title to''
ornull
, or remove the field.rehypePlugins
(I didn't add an automated test for rehype plugin because the dependency will only be used for testing)
routeBasePath
routeBasePath: ''
scripts and stylesheets